psp-9457 leases allow disposed properties to be added. #4532
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
See CodeCov Report Here: https://app.codecov.io/github/bcgov/psp/pull/4532 |
3 similar comments
|
See CodeCov Report Here: https://app.codecov.io/github/bcgov/psp/pull/4532 |
|
See CodeCov Report Here: https://app.codecov.io/github/bcgov/psp/pull/4532 |
|
See CodeCov Report Here: https://app.codecov.io/github/bcgov/psp/pull/4532 |
asanchezr
reviewed
Dec 16, 2024
Comment on lines
548
to
554
| var isDisposedOrRetired = existingPropertyLeases.Any(p => p.Property.IsRetired.HasValue) | ||
| || propertyWithAssociations?.PimsDispositionFileProperties?.Any(d => d.DispositionFile.DispositionFileStatusTypeCode == DispositionFileStatusTypes.COMPLETE.ToString()) == true; |
There was a problem hiding this comment.
question: the old logic had this x.Property.IsRetired.HasValue && x.Property.IsRetired.Value to account for NULLABLE retired flag to have a value (and that the value is true).
However the new/fixed logic is only checking that "IsRetired" is not null. Shouldn't we also check that it is true as well below?
existingPropertyLeases.Any(p => p.Property.IsRetired.HasValue)
asanchezr
reviewed
Dec 16, 2024
| var propertyRepository = this._helper.GetService<Mock<IPropertyRepository>>(); | ||
| var userRepository = this._helper.GetService<Mock<IUserRepository>>(); | ||
|
|
||
| PimsProperty disposedProperty = new PimsProperty() |
There was a problem hiding this comment.
nit: disposedProperty -> retiredProperty
asanchezr
reviewed
Dec 16, 2024
Comment on lines
687
to
691
| [Fact] | ||
| public void UpdateProperties_MatchProperties_Success_NoInternalId() | ||
| { | ||
| // Arrange | ||
| var lease = EntityHelper.CreateLease(1); |
There was a problem hiding this comment.
I believe this test was already added in your other PR. Not sure if it would end up in a duplicate test when both PRs get merged
|
See CodeCov Report Here: https://app.codecov.io/github/bcgov/psp/pull/4532 |
1 similar comment
|
See CodeCov Report Here: https://app.codecov.io/github/bcgov/psp/pull/4532 |
devinleighsmith
force-pushed
the
psp-9457
branch
2 times, most recently
from
f1ef8b4 to
b1fb3a3
Compare
|
See CodeCov Report Here: https://app.codecov.io/github/bcgov/psp/pull/4532 |
3 similar comments
|
See CodeCov Report Here: https://app.codecov.io/github/bcgov/psp/pull/4532 |
|
See CodeCov Report Here: https://app.codecov.io/github/bcgov/psp/pull/4532 |
|
See CodeCov Report Here: https://app.codecov.io/github/bcgov/psp/pull/4532 |
devinleighsmith
force-pushed
the
psp-9457
branch
from
b1fb3a3 to
ea801a2
Compare
|
See CodeCov Report Here: https://app.codecov.io/github/bcgov/psp/pull/4532 |
1 similar comment
|
See CodeCov Report Here: https://app.codecov.io/github/bcgov/psp/pull/4532 |
devinleighsmith
added a commit
that referenced
this pull request
Dec 19, 2024
* PSP-9565: Changes on automation test set to accomodate GHA (#4516) * data changes * Testing browsers * changing .net 6.0 to .net 8.0 * Deleting EdgeDriver nuget package * Changes on webdriver config * Update integration-test.yml * Changes on automation test set - IS94 * Changes to adapt GHA * Changing checklist button to explicit path * Correcting a research file element * CI: Bump version to v5.7.0-94.21 * psp-9500 Scheduler microservice (#4483) * split off geoserver functionality into a microservice - update docker and ci/cd to support. * psp-9500 scheduler microservice. * change service scope * Readme updates. * github action corrections. --------- Co-authored-by: Smith <[email protected]> * CI: Bump version to v5.7.0-94.22 * Bump version to IS95 (#4518) * CI: Bump version to v5.7.0-95.1 * PSP-9569 : H 120 document- Generated document shows full names, inste… (#4519) Co-authored-by: Herrera <[email protected]> * CI: Bump version to v5.7.0-95.2 * Github action fixes (#4520) * CI: Bump version to v5.7.0-95.3 * Lease Historical file alignment fix (#4521) Co-authored-by: Alejandro Sanchez <[email protected]> * CI: Bump version to v5.7.0-95.4 * PSP-9517 Remove "cannot determine" region dropdown from User Management screen under Admin Tools (#4522) * Remove "Cannot determine" region from user management page * Test updates * CI: Bump version to v5.7.0-95.5 * Adding requested tooltip on View and Update forms (#4523) * CI: Bump version to v5.7.0-95.6 * IS-95.00 Database Schema (#4511) * IS-95.00 Database Schema PSP_PIMS | Development Sprint: S95.00 | Design Sprint: 94 | Date: 2024-Dec-03 - Altered tables: - PIMS_ACQUISITION_FILE - PIMS_ACQUISITION_FILE_HIST - PIMS_COMPENSATION_REQUISITION - PIMS_COMPENSATION_REQUISITION_HIST - PIMS_EXPROPRIATION_PAYMENT - PIMS_EXPROPRIATION_PAYMENT_HIST - Added build script: - 007_PSP_PIMS_COMPENSATION_REQUISITION_HIST_Add.sql - Altered build script: - 007_PSP_PIMS_ACQUISITION_FILE_HIST_Add.sql - Altered test script: - 043_PIMS_ACQUISITION_FILE.sql - Requires additional metadata to meet standards * Fixed alter down * Aligning to LATEST --------- Co-authored-by: Manuel Rodriguez <[email protected]> Co-authored-by: Alejandro Sanchez <[email protected]> * CI: Bump version to v5.7.0-95.7 * IS 95 scaffold (#4525) * Generated scaffold * Fixed backend compilation and removed todos. * CI: Bump version to v5.7.0-95.8 * PSP-9283 : UI UX Clean Up - Acquisition - Stakeholders - edit button (#4524) Co-authored-by: Herrera <[email protected]> * CI: Bump version to v5.7.0-95.9 * PSP-8923: UI UX Clean Up - Left Side Menu - Clicked icon stage (#4526) * Adding new yellow tone color * Adding highlighted color to selected path on the side Menu * Color format change * update snapshots --------- Co-authored-by: Alejandro Sanchez <[email protected]> * CI: Bump version to v5.7.0-95.10 * Remove unecessary SetOriginalConcurrencyControlNumber method. (#4527) * CI: Bump version to v5.7.0-95.11 * PSP-9279 UI UX - Acquisition - Agreements & Expropriation - UI Button update for consistency (#4528) * PSP-9279 UI UX cleanup - make generate buttons consistent * Update snapshots * Test updates * CI: Bump version to v5.7.0-95.12 * psp-9632 limit the default bounds when resetting. (#4533) Co-authored-by: Smith <[email protected]> Co-authored-by: Alejandro Sanchez <[email protected]> * CI: Bump version to v5.7.0-95.13 * psp-9715 fix issues adding properties with no locations, and also override research file property updates. (#4530) Co-authored-by: Alejandro Sanchez <[email protected]> * CI: Bump version to v5.7.0-95.14 * [CI] Fix build failures after ubuntu-latest upgrade to 24.04 (#4537) * CI: Bump version to v5.7.0-95.15 * psp-9457 prevent disposed properties from being added to leases. (#4532) * CI: Bump version to v5.7.0-95.16 * disposition override corrections - ensure save redirect functions. (#4536) Co-authored-by: Alejandro Sanchez <[email protected]> * CI: Bump version to v5.7.0-95.17 * psp-9530 allow research files to add retired properties. (#4534) * psp-9530 allow research files to add retired properties. * fix test compilation error. --------- Co-authored-by: Alejandro Sanchez <[email protected]> * CI: Bump version to v5.7.0-95.18 * PSP-8573 | Updated list headers (#4531) * Updated list headers * Added icons * Fixed Typos * lint fixes --------- Co-authored-by: Alejandro Sanchez <[email protected]> * CI: Bump version to v5.7.0-95.19 * PSP-9655 : FT-REG: When creating a new file approximately after 4pm P… (#4540) * PSP-9655 : FT-REG: When creating a new file approximately after 4pm PST timezone, PIMS timestamps the file with the next day's date * - test updates * - test updates --------- Co-authored-by: Herrera <[email protected]> Co-authored-by: Alejandro Sanchez <[email protected]> * CI: Bump version to v5.7.0-95.20 --------- Co-authored-by: Sue Tairaku <[email protected]> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: devinleighsmith <[email protected]> Co-authored-by: Smith <[email protected]> Co-authored-by: Eduardo <[email protected]> Co-authored-by: Herrera <[email protected]> Co-authored-by: Doug Filteau <[email protected]> Co-authored-by: Manuel Rodriguez <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.